py-stockfish / stockfish

Integrates the Stockfish chess engine with Python (Official fork)
https://py-stockfish.github.io/stockfish/
MIT License
30 stars 9 forks source link

Improve Stockfish version parsing #25

Closed knutole closed 1 year ago

knutole commented 1 year ago

Note

Background

Stockfish returns different version formats for releases and development builds:

id name Stockfish 15.1
id name Stockfish 14
id name Stockfish dev-20221219-61ea1534 # ie. dev-YYYYMMDD-<sha>
id name Stockfish 150521 # ie. DDMMYY

Currently the codebase only parses release versions (15.1, 14, etc.) Support is needed for development builds as well. See https://github.com/py-stockfish/stockfish/issues/11 for more background.

Implemented

github-actions[bot] commented 1 year ago

Coverage report

The coverage rate went from 96.17% to 96.56% :arrow_up: The branch rate is 93%.

100% of new lines are covered.

Diff Coverage details (click to unfold) ### stockfish/models.py `100%` of new lines are covered (`96.56%` of the complete file).
knutole commented 1 year ago
Screenshot 2023-05-02 at 01 46 21

https://github.com/py-stockfish/stockfish/pull/19#issuecomment-1509410471

knutole commented 1 year ago

Status? 💭

johndoknjas commented 1 year ago

Seems you both are happy with the branch, and the recent changes all look good to me. So I'll go ahead and merge this.