search

py-stockfish / stockfish

Integrates the Stockfish chess engine with Python (Official fork)
https://py-stockfish.github.io/stockfish/
MIT License
30 stars 9 forks source link

Skip slow tests option #31

Closed johndoknjas closed 1 year ago

johndoknjas commented 1 year ago

This PR allows an additional testing command: "python setup.py skip_slow_tests". It will skip test functions in test_models.py that have a "@pytest.mark.slow" annotation (which we could add to any existing and future tests we want).

While it works fine, I seem to get a new deprecation warning instead of the old ones:

image

For running the tests back on master:

image

Not entirely sure why this is.

@kieferro If you're familiar with this, do you think this is okay? Or is there a better way to implement what this PR is does.

Edit - as an aside, this PR increased the coverage report by over 2%, but I'm not sure what is being covered that wasn't before.

github-actions[bot] commented 1 year ago

Coverage report

The coverage rate went from 93.32% to 95.99% :arrow_up: The branch rate is 92%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

johndoknjas commented 1 year ago

@kieferro Alright, that sounds good. If you're okay with these updates then, I can go ahead and merge the PR.