search

py-vobject / vobject

A full-featured Python package for parsing and creating iCalendar and vCard files
http://py-vobject.github.io/
24 stars 7 forks source link

Dev flake8 #38

Closed da4089 closed 6 months ago

da4089 commented 6 months ago

Merge changes, mostly to project mgmt files, for linter integration.

return42 commented 6 months ago

Just for my information: this PR isn't merged into main line / is merged into dev-flake8 feature branch.

For me it is unusual for a github PR to be merged into a branch other than the main branch. I understand the intention and it is not a problem to merge branches ... but from the github issue tracker's point of view it could give the impression that this PR is already included in the main line and "completed" / "topic closed".

But maybe it's just me who is not used to merge github PR into development lines other than the main line? / Not sure what happens in the github issue tracker when one of the commits includes a line Closes #123 in the commit message?

da4089 commented 6 months ago

I merged your branch into py-vobject/vobject:dev-lint, rather than py-vobject/vobject:master, and then merged my da4089/vobject:dev-flake8 into dev-lint as well. And then continued to push further changes into that branch as well.

I think that when that branch (dev-lint) is merged to master that your original PR will automatically close.