Removed PyICU dependency

py-vobject / vobject

A full-featured Python package for parsing and creating iCalendar and vCard files

http://py-vobject.github.io/

29 stars 7 forks source link

Removed PyICU dependency #40

Closed rsb-23 closed 7 months ago

rsb-23 commented 7 months ago

Issue : #35

PyICU is only used for listing and parsing timezones, which can be replaced with pytz and dateutil.

Checks:

[x] All 42 testcases passed.

Changes:

PyICU functions are replaced with its equivalnet funcs pytz.all_timezones and dateutil.tz.gettz(), as used in tests.py.
main() is split into 2 simpler functions.

da4089 commented 7 months ago

@rsb-23 I think I'd like to merge this for 0.9.x? If you agree, can you make the fixes noted above and test it on Python 2.7, and then it can be merged for 0.9.8. Thanks!

rsb-23 commented 7 months ago

[x] Converted f-strings to .format()
[x] pytz and dateutil added to setup.py and requirements.txt
[x] All 42 tests passed for py27, py37 ... py312

da4089 commented 7 months ago

Thanks @rsb-23!