py-why / dodiscover

[Experimental] Global causal discovery algorithms
https://www.pywhy.org/dodiscover/
MIT License
82 stars 17 forks source link

Add additional CI tests: Mutual Information, Chi square, Monte Carlo #17

Open adam2392 opened 2 years ago

adam2392 commented 2 years ago

LGTM. My only issues are with some of the type hints.

@adam2392 can you comment here on why some flavors are left out? For example:

Originally posted by @robertness in https://github.com/py-why/dodiscover/pull/16#pullrequestreview-1076586407

adam2392 commented 2 years ago

Other tests that I'm trying to use for some projects are:

adam2392 commented 1 year ago

Additional info on the Jonckheree test:

https://www.quantics.co.uk/blog/jonckheere-terpstra-test-ordered-differences/ https://www.stats.ox.ac.uk/~steffen/teaching/fsmHT07/fsm07.pdf https://en.wikipedia.org/wiki/Jonckheere%27s_trend_test

C implementation in R: https://github.com/cran/bnlearn/blob/master/src/tests/discrete/jonckheere.c