Graphviz installation : --include-path not recognized anymore

py-why / dowhy

DoWhy is a Python library for causal inference that supports explicit modeling and testing of causal assumptions. DoWhy is based on a unified language for causal inference, combining causal graphical models and potential outcomes frameworks.

https://www.pywhy.org/dowhy

MIT License

6.88k stars 916 forks source link

Graphviz installation : --include-path not recognized anymore #1172

Closed sinhaharsh closed 1 month ago

sinhaharsh commented 2 months ago

README provides the following command to install graphviz,

pip install pygraphviz --install-option="--include-path=/usr/include/graphviz" \
--install-option="--library-path=/usr/lib/graphviz/"

However this command doesn't work anymore as per https://github.com/pypa/setuptools/issues/2740 It should be modified to

pip install --global-option=build_ext --global-option="-I/usr/local/include/graphviz/" --global-option="-L/usr/local/lib/graphviz" pygraphviz

emrekiciman commented 2 months ago

Thank you @sinhaharsh . I wonder if we should just link to the pygraphviz INSTALL instructions at https://pygraphviz.github.io/documentation/stable/install.html

Thoughts?

sinhaharsh commented 2 months ago

A link to pygraphviz install instructions already exists as a note

emrekiciman commented 2 months ago

Ah, I missed that somehow. Thanks @sinhaharsh . Would you like to submit a PR with your README change? This will help record your contribution.

sinhaharsh commented 2 months ago

It seems the note is present at the documentation page for Contributing-Code. However, no such note is present in the README and on the installation page.

There are only 3 occurrences for the following code across the repository.

Sure. I will send a PR for these changes.