py-why / dowhy

DoWhy is a Python library for causal inference that supports explicit modeling and testing of causal assumptions. DoWhy is based on a unified language for causal inference, combining causal graphical models and potential outcomes frameworks.
https://www.pywhy.org/dowhy
MIT License
7.15k stars 935 forks source link

falsify_graph uses np.math which does not exist #1268

Open samiislam opened 1 month ago

samiislam commented 1 month ago

Describe the bug On line 935 https://github.com/py-why/dowhy/blob/e79d01280b1f8c7e54c0bda93ceddc932f7eedea/dowhy/gcm/falsify.py#L935 the method falsify_graph uses np.math which does not work.

Steps to reproduce the behavior

  1. Use falsify_graph in some code with valid parameters
  2. Errors out: AttributeError: module 'numpy' has no attribute 'math'

Expected behavior falsify_graph returns without error

Version information:

bloebp commented 1 month ago

Hey, can you check which numpy version you have? That might be outdated.

bloebp commented 1 month ago

Regardless, addressed it here: https://github.com/py-why/dowhy/pull/1273