amit-sharma
commented
2 years ago Hey, @esmucler thanks for reaching out. I'm familiar with your work and I think it will be a great addition to DoWhy.
Thinking in terms of user-facing API, here's a proposal: the identify_effect method already contains options to constrain the adjustment set returned. We have "exhaustive", "minimal-adjustment", "maximal-adjustment" and a "default" that is a heuristic mix of minimal and maximum. One option is to add more options here for the user, which may include, "optimal-adjustment", "optimal-minimal-adjustment" and "optimal-minimum-cost-adjustment". Would something like this work?
In terms of code structure, it may be easiest to add a new class for your method under causal_identifiers folder. Then you may need to modify identify_ate_effect method in CausalIdentifier class to add a call to your class.
In any case, feel free to raise a PR. You may also consider submitting a draft (incomplete) PR so that we can review the code structure and API before all the detailed code is added.
emrekiciman
esmucler
Hello DoWhy team.
Congrats on the great work on this package! I wonder if you would be interested in a contribution to the package. First, a brief intro.
In a series of papers with co-authors (1, 2, and 3, the last one currently under review in the Journal of Causal Inference), we have developed theory and algorithms to compute efficient (meaning low variance) adjustment sets for estimating the average treatment effect of a treatment on an outcome under a non-parametric causal graphical model. Our results allow for hidden variables in the graph (as long as at least one adjustment set is comprised of observable variables), and the possibility of individualised treatments (in which the values of the intervention variable depend on some other set of variables).
More precisely, suppose we are given a causal graph G specifying:
Suppose moreover that there exists at least one adjustment set with respect to A and Y in G that is comprised of observable variables. Consider the following definitions:
Under these assumptions, we have shown that optimal minimal and optimal minimum cost adjustment sets always exist, and can be computed in polynomial time. We also provide a sufficient criterion for the existence of an optimal adjustment set and a polynomial time algorithm to compute it when it exists.
These results are not only valid for non-parametric graphs and estimators, but also by virtue of results in this paper, for linear structural equation models and OLS estimators.
We have implemented these algorithms in the optimaladj package, with routines from networkx doing most of the algorithmic heavy lifting. We believe they would be a nice addition to the DoWhy package.
Going back to my first point. Would you be interested in a PR that incorporates these algorithms into DoWhy? They could supplement the already implemented backdoor identification strategy.
Best, Ezequiel Smucler