Open Padarn opened 1 year ago
hey @padarn, did your PR #806 fix this issue too? Or do you still see this error?
Sorry for the slow reply: No it doesn't fix the issue. I wasn't sure if the behaviour I suggest above would be the desired one. If so I'll submit a new PR.
Describe the bug In some pathological cases its possible for the p-value of a refuter to be
NaN
: In particular if al of the simulations return the same value.Identified while looking at https://github.com/py-why/dowhy/issues/804
Steps to reproduce the behavior
Produces
Expected behavior This is unclear, which is why I am opening an issue rather than submitting a bug report.
Version information:
The root cause of this is in the p-value calculation of the refuter which assumes that the standard deviation of the simulations is well defined.
This would be easy to fix by setting the p-value to 1 in this scenario. WDTY?