search

py-why / dowhy

DoWhy is a Python library for causal inference that supports explicit modeling and testing of causal assumptions. DoWhy is based on a unified language for causal inference, combining causal graphical models and potential outcomes frameworks.
https://www.pywhy.org/dowhy
MIT License
7.01k stars 922 forks source link

Unpin numpy #959

Closed Zethson closed 1 year ago

Zethson commented 1 year ago

Fixes #958

emrekiciman commented 1 year ago

@kbattocchi @amit-sharma any reason not to unpin numpy? all the checks pass. Thanks

emrekiciman commented 1 year ago

thanks @Zethson!

amit-sharma commented 1 year ago

I think there was an issue with numba before where it was only compatible with lower versions of numpy. That is probably fixed now. @kbattocchi am I correct?

kbattocchi commented 1 year ago

@amit-sharma: that's possible; as I recall there was an issue with numba that prevented us from supporting python 3.11 at one point on the econml side, but it looks like dowhy is limited to python<3.11 anyway. In general numpy releases have not posed backwards compatibility issues for econml so we have not added a constraint to a specific version.

emrekiciman commented 1 year ago

All right. given your comments, @amit-sharma @kbattocchi and the passing checks, I'm going to go ahead and merge this in then!

emrekiciman commented 1 year ago

@all-contributors please add @Zethson for code

allcontributors[bot] commented 1 year ago

@emrekiciman

I've put up a pull request to add @Zethson! :tada: