Check edge types allowed given a `graph_type` passed in export functions

py-why / pywhy-graphs

[Experimental] Causal graphs that are networkx-compliant for the py-why ecosystem.

https://py-why.github.io/pywhy-graphs/dev/index.html

MIT License

47 stars 8 forks source link

Check edge types allowed given a `graph_type` passed in export functions #61

Open adam2392 opened 1 year ago

adam2392 commented 1 year ago

          What happens if a user has `graph_type="dag"` instead here? Will this function detect that there are `o->` edges and prevent that? Clearly the imported file does not represent a DAG so we shouldn't let the user make this mistake. Or we should have clear tests to show what happens when you import a graph under a different graph assumption than the one it was created with

_Originally posted by @jaron-lee in https://github.com/py-why/pywhy-graphs/pull/60#discussion_r1127972816_

adam2392 commented 1 year ago

This is mainly for robustness and error-checking within the export submodule