ellabeck03
commented
3 months ago Hi, I have replaced the old plotting tests and that now seems to be working fine. Would you like me to replace paths with os.path objects any time I spot a FileNotFound error caused by them? I did it for the test_fispact_analysis file just to confirm that every test in the file passed, and it all worked well. I am fairly sure I have updated the fork and removed all .pyc files created by running the tests (currently researching a way to stop these being generated). I determined whether or not a sample was cooling based on the "Irradn/Cooling" labels generated in the first column of the output summary table, but please let me know if there is a better way to do this and I will implement it :)
need to remove all the .pyc and vscode extra files. need to update your fork so it accounts for the changes already made to neut constants. looks like the issues with the test data were windows using the opposite slash compared to linux, so you proposed use of os.path objects is probably the correct solution.
currently there is a test fail as you need to replace the old tests with updated ones using the new function. after that i will do a bit more of a code review, its not clear that the changes to the cooling step part are quite right.