search

py4dstem / py4DSTEM

GNU General Public License v3.0
212 stars 142 forks source link

Which functions are supported for polar transforms of data #114

Closed tcpekin closed 3 years ago

tcpekin commented 4 years ago

Hi @bsavitzky, I want to polar transform my stack, but I'm unsure if I should use the cartesian_to_polarelliptical_transform.py code or the functions found in ellipticalCoords.py. I think both need to be updated to work with the new ellipse fitting functions now as well, since A is no longer a free parameter, and instead we have a radius value, and I would rather fix the one that will be kept going forward, versus some legacy code. Also, I'm not sure 100% that they need to be updated yet. If they have been already please let me know.

Thanks, Tom

bsavitzky commented 4 years ago

Yup, this needs to be cleaned up to remove the older functions. Use cartesianDataAr_to_polarEllipticalDataAr, found in ellipticalCoords.py.

On Thu, Apr 23, 2020 at 1:57 AM tcpekin notifications@github.com wrote:

Hi @bsavitzky https://github.com/bsavitzky, I want to polar transform my stack, but I'm unsure if I should use the cartesian_to_polarelliptical_transform.py code or the functions found in ellipticalCoords.py. I think both need to be updated to work with the new ellipse fitting functions now as well, since A is no longer a free parameter, and instead we have a radius value, and I would rather fix the one that will be kept going forward, versus some legacy code.

Thanks, Tom

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/py4dstem/py4DSTEM/issues/114, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQYYNOV7CRXNN4T5WM47TLRN77GHANCNFSM4MO36HCQ .

tcpekin commented 4 years ago

Awesome, thanks for the quick response.

On Thu, Apr 23, 2020 at 12:20 PM bsavitzky notifications@github.com wrote:

Yup, this needs to be cleaned up to remove the older functions. Use cartesianDataAr_to_polarEllipticalDataAr, found in ellipticalCoords.py.

On Thu, Apr 23, 2020 at 1:57 AM tcpekin notifications@github.com wrote:

Hi @bsavitzky https://github.com/bsavitzky, I want to polar transform my stack, but I'm unsure if I should use the cartesian_to_polarelliptical_transform.py code or the functions found in ellipticalCoords.py. I think both need to be updated to work with the new ellipse fitting functions now as well, since A is no longer a free parameter, and instead we have a radius value, and I would rather fix the one that will be kept going forward, versus some legacy code.

Thanks, Tom

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/py4dstem/py4DSTEM/issues/114, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABQYYNOV7CRXNN4T5WM47TLRN77GHANCNFSM4MO36HCQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/py4dstem/py4DSTEM/issues/114#issuecomment-618317462, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACIANAB5OS6JMTTV53TSZ4LROAI7JANCNFSM4MO36HCQ .

alex-rakowski commented 3 years ago

Looks like cartesian_to_polarelliptical_transform.py has been removed, assume this closeable?