py4dstem / py4DSTEM

GNU General Public License v3.0
202 stars 140 forks source link

fix probe norm bug #656

Closed bsavitzky closed 5 months ago

bsavitzky commented 5 months ago

This PR fixes a bug in probe generation, where non-zero pixels outside of the center beam caused normalization issues.

Note that the solution here makes use of the Probe.measure_disk method instead of the datacube.get_probe_size method which implement similar functionality to avoid breaking changes elsewhere for now. A more comprehensive consolidation of functionality (there is a third method with similar functionality in process.calibration.probe, as well as some redundant metadata storage) will be implemented in v15. For (upcoming) v14.15+, using Probe.measure_disk is recommended.