search

py4dstem / py4DSTEM_tutorials

Sample code for py4DSTEM
GNU General Public License v3.0
37 stars 31 forks source link

ACOM_03_Au_NP_sim.ipynb bugs #11

Open sezelt opened 2 years ago

sezelt commented 2 years ago

Running the ACOM_03 notebook as downloaded, cell 25 gives the following error:

---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
/var/folders/ts/tq6v7mks7hvg37ys5zvs1c2w0000gn/T/ipykernel_3012/3733081456.py in <module>
     14 
     15 # Fit an ellipse to the elliptically corrected bvm
---> 16 qx0_corr,qy0_corr,a_corr,e_corr,theta_corr = py4DSTEM.process.calibration.fit_ellipse_1D(bvm_ellipsecorr,(qx0,qy0),(qmin,qmax))
     17 
     18 py4DSTEM.visualize.show_elliptical_fit(

NameError: name 'qmin' is not defined

I think someone changed qmin, qmax to be a list called qrange and never actually tested the notebook in a fresh state.