Changed how semiangle, defocus, rotation are printed in ptycho02_MoS2.ipynb

py4dstem / py4DSTEM_tutorials

Sample code for py4DSTEM

GNU General Public License v3.0

37 stars 31 forks source link

Changed how semiangle, defocus, rotation are printed in ptycho02_MoS2.ipynb #27

Closed jhuang97 closed 4 months ago

jhuang97 commented 4 months ago

Print those values using f-strings instead of rounding and str().

The diff should look okay if you set it to "Hide whitespace", otherwise the diff is large. I am guessing the line endings don't match somehow...

gvarnavi commented 4 months ago

Thanks for the PR - we were actually in the middle of refactoring all the phase_contrast tutorial notebooks, so this PR currently points to nowhere (the file has been renamed phase_retrieval_02.ipynb.

I saw this slightly late to incorporate, but it seems like your issue might be addressed in the new notebook (which uses more decimal points for the printing). Feel free to open a new PR if this is not the case.

jhuang97 commented 4 months ago

Seems like I decided to try out the ptycho notebooks just a bit too early :) Thanks for the updates!