py4n6 / pytsk

Python bindings for The Sleuth Kit (libtsk)
Apache License 2.0
92 stars 24 forks source link

Changes to generation of pytsk3.c for reproducible build #81

Closed lamby closed 3 years ago

lamby commented 3 years ago

Whilst working on the Reproducible Builds effort I noticed that pytsk could not be built reproducibly.

This is because it generated a pytsk3.c file in a nondeterministic manner, specifically by naively iterating over a Python set() structure.

(I originally filed this in Debian as bug #992060.)

joachimmetz commented 3 years ago

@lamby thx for flagging, changes LGTM, I'll add a comment to indicate why the sorted is there and merge them once tests pass