search

pyGrowler / Growler

A micro web-framework using asyncio coroutines and chained middleware.
http://www.growler.rocks
Apache License 2.0
686 stars 29 forks source link

GrowlerHTTPResponder' object has no attribute 'client_query' #9

Closed leonardoo closed 8 years ago

leonardoo commented 8 years ago

when i try to get get a param from a url, the app gave me this error

ERROR:growler.router:4441216280:'GrowlerHTTPResponder' object has no attribute 'client_query' ERROR:growler.middleware_chain:4437457384:'GrowlerHTTPResponder' object has no attribute 'client_query' https://gist.github.com/leonardoo/cc9c0ae4ac0593553b4bfea239758528

the fix is change:

....
    @property
    def query(self):
        return self._protocol.client_query

for this:

....
    @property
    def query(self):
        return self._protocol.parsed_query
akubera commented 8 years ago

Thanks for your contribution! That bug was introduced a while ago when I was trying to move away from the parser storing data and putting more client information into the Protocol object. The target for that particular property was this attribute (otherwise unused). This also shows I need to buckle down and get more test coverage.