pyMBE-dev / pyMBE

pyMBE provides tools to facilitate building up molecules with complex architectures in the Molecular Dynamics software ESPResSo. For an up-to-date API documention please check our website:
https://pymbe-dev.github.io/pyMBE/pyMBE.html
GNU General Public License v3.0
6 stars 8 forks source link

Fix wrong setup of LJ, improve CI and coverage #63

Closed pm-blanco closed 4 months ago

pm-blanco commented 4 months ago

Quite dense PR, I would appreciate at least two reviewers. Thank you @mariusaarsten for the help while addressing this PR. Partially solves #58.

Bug fixes:

Code improvements:

New CI tests for the following functions (some of them very much needed):

I ran the functional tests and they all pass. I also ran longer tests and the results seem pretty similar to the results in our publication.

Current coverage: 77% total, 70% in pymbe.py

pm-blanco commented 4 months ago

@davidbbeyer will you have time to take a look early next week? Otherwise I will simply proceed to merge this PR, this commit has been used by my students for the last two weeks and reviwed by @paobtorres so it seems quite stable 🙂

davidbbeyer commented 4 months ago

@pm-blanco Yes, on Monday.