Closed DanHickstein closed 6 years ago
As discussed in https://github.com/pyNLO/PyNLO/pull/36#issuecomment-219893717, I think that we intended to remove the factor of 1e12 in the noise calculations on lines 661 and 664 of PulseBase.py.
1e12
This PR addresses that, enables the calculate_coherence function to return the input pulse (which I've found useful), and modifies the SSFM_coherence example to accommodate this.
Cross referencing to our other discussion of noise/coherence in https://github.com/pyNLO/PyNLO/issues/22
As discussed in https://github.com/pyNLO/PyNLO/pull/36#issuecomment-219893717, I think that we intended to remove the factor of
1e12in the noise calculations on lines 661 and 664 of PulseBase.py.This PR addresses that, enables the calculate_coherence function to return the input pulse (which I've found useful), and modifies the SSFM_coherence example to accommodate this.
Cross referencing to our other discussion of noise/coherence in https://github.com/pyNLO/PyNLO/issues/22