search

pyOpenSci / peer-review-metrics

A repo where we collect peer review metrics
https://www.pyopensci.org/peer-review-metrics
0 stars 4 forks source link

Add plots of editors load in current-reviews-data.ipynb #24

Closed santisoler closed 2 months ago

santisoler commented 3 months ago

Add a new "Editors load" section to the current-reviews-data.ipynb with plots of number of contributions by each editor in each quarter. Include a new function in functions.py to count number of contributions per quarter.

This PR was created during SciPy2024 sprints.

lwasser commented 2 months ago

hey @santisoler is this PR still a WIP or is it meant to be reviewed? many thanks!! 🙌🏻

santisoler commented 2 months ago

Hi @lwasser! Sorry for not updating the status of this PR. The plots are working now, but maybe we want to improve how they look or customize them a little bit. I would appreciate if you could review them. Thanks for asking!

lwasser commented 2 months ago

hi @santisoler wonderful !! thank you. i'll put this on my list of pr's to review!! thank you again for the help here!!

lwasser commented 2 months ago

@santisoler here is another idea if you are short on time! We could merge this PR as is and if you have time in the future - you could work on edits. If not, no worries. I'm suggesting this only because i am going to reorganize this repo a bit to make space for other types of organization metrics. I'd love to get this pr merged without rushing you! The plot works and is great as is.

We can finesse it in future pr's. Does that work for you?

lwasser commented 2 months ago

Hi there 👋🏻 I just rebased this branch after making some changes to the directory structure to support an upcoming report that caused a merge conflict!

I've created a small package in metrics-theme/src called metrics theme. The functions.py module can be added there, and I added a small plot theme module as well, so our plots are all consistent!

santisoler commented 2 months ago

Hi @lwasser! Sorry for the delayed reply! Thanks for merging the PR. I started working on the points you mentioned, but haven't pushed yet (coming back from vacations requires some time to catch up). I'll open another PR with those changes if that works for you.