Closed lwasser closed 8 months ago
@kierisi this pr is a bit trickier in that i didn't edit the entire file - the gif below should show you how you can view additional lines of text in the file. then just leave comments for things you think should be changed lower down in the pull request if you can't edit it inline and suggest changes as you did in the peer review page.
feel free to ask if this approach isn't clear - but i'd love your review of the entire page!! thank you.
here is a rendered version of this page again all feedback is welcome.
i am done tweaking - i just simplified both of the partner page graphics. @willingc thank you for the alt tag note - we have to add those :) i just wanted to make sure people liked the diagrams first!!! but i'm stopping work on the diagrams now for the evening. i'm hoping what i just pushed makes for a much cleaner / readable graphic. they felt too complex to me for the small space they were in.
most recent version of the page rendered is here i'm done pushing to this pr for the evening! promise :)
@lwasser I can't seem to add suggestions to most of the file, as it's greyed out. any suggestions?
@lwasser I can't seem to add suggestions to most of the file, as it's greyed out. any suggestions?
@kierisi yes - that is because i didn't edit the top of the page. i have a few ideas.
i'm open to whatever way you're prefer to move forward here!! i know this isn't ideal. you can only add inline comments on changes i've made to specific lines but i know the entire page needs work.
@kierisi i forgot that we can add buttons to the template sections on the website !! we could even add font awesome icons in the future if we wish to!!! but i've gone through and added more "call to actions" in all of the sections following our web flow conversations!! and now i'll stop using so many !!!!!!! :)
ok i'm really happy with this page now. @kierisi have a look when you have a moment at the final rendered version and let me know what you think!! i think we can merge this next week and call this task complete!
Looks good to me! I say 🚢 when you're ready!
ok cool. and i didn't full understand your comment @kierisi about who we're talking to until i read it through again. you are right. maybe we can think about this as a "search and destroy" mission once we decide what "voice" second person vs third we use in our website text. Yay ok i'll go ahead and merge this... 🚢 :shipit:
This PR cleans up the partner page - specifically it ensures less inline html and aligns styles between this page and the peer review page which we are working on #287
@kierisi i'm going to ask you to review this one as well!! any and all feedback welcome here. we can totally redo the text as needed i'm not wedded to it.
Adding a TODO list from our canva board