pyOpenSci / pyopensci.github.io

This is the website for pyOpenSci. Contributions welcome!!
https://www.pyopensci.org
Other
37 stars 61 forks source link

pyOS march 2024 newsletter #346

Closed kierisi closed 6 months ago

kierisi commented 6 months ago

back-dated post for the March 2024 newsletter

lwasser commented 6 months ago

errors on this build from the raw logs 😢 htmlproofer is making me cry

2024-04-01T14:52:03.3144541Z Ran on 58 files! 2024-04-01T14:52:03.3144982Z 2024-04-01T14:52:03.3147150Z At _site/blog/pyos-newsletter-april-2024.html:540: 2024-04-01T14:52:03.3148511Z 2024-04-01T14:52:03.3148917Z http://eepurl.com/iM7SOM is not an HTTPS link 2024-04-01T14:52:03.3149733Z 2024-04-01T14:52:03.3151088Z At _site/blog/pyos-newsletter-march-2024.html:528: 2024-04-01T14:52:03.3151779Z 2024-04-01T14:52:03.3153998Z 2024-04-01T14:52:03.3160712Z http://eepurl.com/iM7SOM is not an HTTPS link 2024-04-01T14:52:03.3161377Z 2024-04-01T14:52:03.3161876Z For the Links > External check, the following failures were found: 2024-04-01T14:52:03.3162515Z 2024-04-01T14:52:03.3162996Z At _site/blog/pyos-newsletter-april-2024.html:48: 2024-04-01T14:52:03.3167208Z 2024-04-01T14:52:03.3169364Z External link https://www.pyopensci.org/blog/pyos-newsletter-april-2024.html failed (status code 404) 2024-04-01T14:52:03.3170262Z 2024-04-01T14:52:03.3170553Z At _site/blog/pyos-newsletter-march-2024.html:48: 2024-04-01T14:52:03.3170885Z 2024-04-01T14:52:03.3171531Z External link https://www.pyopensci.org/blog/pyos-newsletter-march-2024.html failed (status code 404) 2024-04-01T14:52:03.3172213Z 2024-04-01T14:52:03.3172736Z For the Links > Internal check, the following failures were found: 2024-04-01T14:52:03.3236856Z 2024-04-01T14:52:03.3237639Z * At _site/blog/pyos-newsletter-april-2024.html:536: 2024-04-01T14:52:03.3238267Z 2024-04-01T14:52:03.3239219Z internally linking to media@pyopensci.org, which does not exist

@kierisi we should also get you setup with precommit so it fixes format issues for you locally.

the only actually thing to fix here is this: http://eepurl.com/iM7SOM is not an HTTPS link

kierisi commented 6 months ago

@lwasser that would be great! I pushed the https fixes through for march and april - the default for forms in Mailchimp is http, so it's something I'll just need to keep an eye on.

kierisi commented 6 months ago

3. let's get the files cleaned up - either include both march/april here in one pr or delete april from this pr and i'll look at it separately in the other pr. In general smaller pr's are better! easier to merge.

done! this one's on me - I had separate PRs and branches, but wasn't paying attention to the files being carried over.

lwasser commented 6 months ago

@kierisi just a note on pre-commit. we have a bot setup (pre-commit.ci). so above you can see the pre-commit.ci bot failed the pr. we can fix it in the pr if it's not a spelling error. you can click on the above build failure and see what failed and it also gives instructions for adding a comment here to this PR to automagically fix this pr (it will add a commit for you with the fixes). i am going to do that now.

the alternative is setting up pre-commit locally so you are always pushing "clean" commits. we can talk more about that wednesday. but watch what happens when i add the pre-commit autofix comment below.

lwasser commented 6 months ago

pre-commit.ci autofix

lwasser commented 6 months ago

See above - the one issue with this is that if you want to keep adding to this pr, then you'll have to force push to the pr OR pull down the new commit before making other changes. so that is why if you are actively working on a pr it could be nice to just fix things locally.

Screenshot 2024-04-01 at 4 48 52 PM
lwasser commented 6 months ago

Cool - all errors gone except the usual new page error - merging

For the Links > External check, the following failures were found: 2024-04-01T22:51:55.4069225Z 2024-04-01T22:51:55.4069819Z * At _site/blog/pyos-newsletter-march-2024.html:48: 2024-04-01T22:51:55.4070393Z 2024-04-01T22:51:55.4071275Z External link https://www.pyopensci.org/blog/pyos-newsletter-march-2024.html failed (status code 404) 2024-04-01T22:51:55.4072325Z

kierisi commented 6 months ago

@lwasser great! I've got pre-commit set up locally, so I'll start integrating that into my workflow (and will go test out the magic comment on my april newsletter PR!)