search

pyOpenSci / pyopensci.github.io

This is the website for pyOpenSci. Contributions welcome!!
https://www.pyopensci.org
Other
38 stars 61 forks source link

Fix navigation / potential website overhaul #355

Open lwasser opened 7 months ago

lwasser commented 7 months ago

Referenced in #335 by @kierisi

overall one thing I've noticed with our website that I find a bit frustrating is that when I click on a header item (such as Learn), I have to choose one of the drop-down items. what I want//expect instead is to be able to click Learn, and then be taken to a Learn landing page that then lets me navigate out to the sub-headers (tutorials, blog, ask a question).

design-wise, there's almost too much white space throughout the page, and I feel like I have to scroll quite a bit to get to information. I don't know how much of this is a limitation of the framework we're using, but it could be nice to tighten things up.

I also think changing the header image to an illustration would help with the overall design of the page, making all of the imagery more internally consistent.

@kierisi this is great feedback. this pr however is focused on the learn page. how about you open an issue so we can talk about bigger things like navigation etc. the header drop downs is tricky. i probably could fix it but i ended up actually writing the javascript myself for those drop downs and it took forever. It's not trivial to add that fix where a click can actually land on a section and open a drop down as you don't know what the user wants to do hover or click. This also gets into responsiveness where on a mobile phone you will always want to click as hover isn't really a thing. so to implement this i'd prefer to move to a platform like bootstrap or tailwind (probably not tailwind!) but you know what i mean... this would be a big migration which the site needs.

so while i appreciate this feedback, it's best in it's own pr and should align with someone else rebuilding the website as we want it using a framework that makes sense and is responsive. minimal mistakes never supported drop downs or bootstrap (and the infra is super dated)! i thing even the grids i adds flex boxes and grid functionality to the theme! it's super hacked.

Originally posted by @lwasser in https://github.com/pyOpenSci/pyopensci.github.io/issues/335#issuecomment-2032861670

lwasser commented 7 months ago

@kierisi i forgot github allows you to turn a comment into an issue automatically. i'm doing that! ✨ so no need to open issues

jonkiparsky commented 5 months ago

@lwasser I notice that the PyOpenSci logo generally links to the packaging page. I'm not sure if this is intentional, but my expectation as a naive user would be that this would link to the home page.

If this is indeed a bug, it might be a useful beginner ticket for someone to work on. If so, I'd be glad to open a separate ticket to facilitate that. Alternatively, this might just be something to consider under the general theme of navigation, in which case there is probably no further action required.

lwasser commented 1 month ago

@all-contributors please add @jonkiparsky for bug, idea

allcontributors[bot] commented 1 month ago

@lwasser

I've put up a pull request to add @jonkiparsky! :tada: