pyOpenSci / pyopensci.github.io

This is the website for pyOpenSci. Contributions welcome!!
https://www.pyopensci.org
Other
37 stars 61 forks source link

Update contributor and review data #434

Closed github-actions[bot] closed 3 months ago

github-actions[bot] commented 3 months ago

Automated changes by create-pull-request GitHub action

sneakers-the-rat commented 3 months ago

Seems bad to delete all the packages lol

lwasser commented 3 months ago

@sneakers-the-rat there are two issues! the blank file is fixed here: https://github.com/pyOpenSci/pyosMeta/pull/172 we updated the label names! easy. but also it's still failing because we have a new reviewer format. instead of using

reviewer_1 and reviewer_2 we are moving to a

reviewerselement in our package yaml generation / pydantic model.

So i think we need to

  1. clean up the code to ensure it parses the reviewer field correctly (maybe this is needed)
  2. create a validator that will ingest both reviews with reviewer_1, _2 or 3 OR the new format which is reviewers: list of reviewer github handles here.

If you have any bandwidth to work on a pydantic validator in our pyos meta package please lemme know. but otherwise i'm gonna try to fix it :upside. lessons learned to open issues immediately when we update the review template and / or labels!!

sneakers-the-rat commented 3 months ago

here's my take: https://github.com/pyOpenSci/pyosMeta/pull/174

lwasser commented 3 months ago

i am going to merge this! i suspect the date inconsistencies will cause a jekyll issue but let's see.