search

pyOpenSci / pyos-package-template

A Python package template that supports the pyOpenSci pure Python packaging tutorial
BSD 3-Clause "New" or "Revised" License
15 stars 11 forks source link

Configure PyUp to maintain dependency versions #12

Closed mbjoseph closed 5 years ago

mbjoseph commented 5 years ago

This PR adds a config file for PyUp, so that pinned package versions are updated automatically via pull requests that PyUp submits.

There are a couple of other little things that this cleans up, so that the CI tests on the PyUp PRs are meaningful:

  1. Drop tests for python 2 and 3.4
  2. Add tests for python 3.7
  3. Remove unnecessary deploy code from .travis.yml (this package is not deployed to PyPI)

This PR relates to an issue raised in #7 by @xmnlab about pinning to outdated package versions.

@kysolvik or @lwasser would you mind giving this a review?

mbjoseph commented 5 years ago

I think so -- that's what this line is (supposed to be) doing: https://github.com/pyOpenSci/cookiecutter-pyopensci/pull/12/files#diff-50f285e3023eb0b37f3dc8671b7dace9R4

lwasser commented 5 years ago

ahhh ok appveyor is failing. this looks so great @mbjoseph lemme give this a look. but otherwise - THANK YOU!! this will be a great upgrade to our cookiecutter template

lwasser commented 5 years ago

before i go any further with appveyor -- it looks like there are a few python 2.x builds

Screen Shot 2019-09-20 at 3 57 40 PM

what do you guys think about dropping python 2.x support? it's being dropped everywhere these days i think

lwasser commented 5 years ago

this failure may be a pip thing

You are using pip version 8.1.1, however version 19.2.3 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command
lwasser commented 5 years ago

thanks @mbjoseph !! i'm with you on that commit!! :) i also created a discourse poll just to engage people but i feel pretty strongly that we should stick to 3.x!!

mbjoseph commented 5 years ago

Ok - let's hold off on merging this for now. I need to debug this AppVeyor stuff -- looks like we're running into permissions errors...

lwasser commented 5 years ago

eeks... thanks @mbjoseph appveyor has been buggy this week. appreciate the help with this!!

xmnlab commented 5 years ago

some projects have moved to azure pipelines. does make sense for this repo move CI to azure pipelines?

mbjoseph commented 5 years ago

@xmnlab good suggestion - feel free to open a separate issue for Azure CI and we can discuss there (I don't want to lose that conversation in this PR).

mbjoseph commented 5 years ago

Ok, after some fiddling AppVeyor builds are now passing. @lwasser feel free to merge this if it looks good to you!

lwasser commented 5 years ago

thank you @mbjoseph this looks great. we appreciate your help with this.!!!