search

pyOpenSci / pyos-package-template

A Python package template that supports the pyOpenSci pure Python packaging tutorial
BSD 3-Clause "New" or "Revised" License
15 stars 11 forks source link

Add shortcut to accept defaults #44

Closed Midnighter closed 4 weeks ago

Midnighter commented 1 month ago

Fix #41

Implement a question in the template that let's you skip and accept default values. You have an option for the full template and one for the minimal template being created.

I'm definitely creating technical debt here, as the template is made quite a bit more complicated and all the different paths should be tested, but I'm not including any tests 😬. I figure it's the weekend and you might want to use this next week @lwasser.

lwasser commented 1 month ago

hi @Midnighter thank you for this! i'll test it out locally (and let's see what others say). i hear you on the technical debt and will consider that as i play with this - likely tomorrow!

blink1073 commented 4 weeks ago

The no choice for use_default wasn't working, I pushed a fix. Now all three options LGTM, thanks @Midnighter!

lwasser commented 4 weeks ago

@Midnighter given @blink1073 approved please go ahead and merge! I don't want to to be a blocker here!

We can cut a release and I'll play w it tomorrow after our fall festival sessions are done!!

Midnighter commented 4 weeks ago

Cheers!