search

pyOpenSci / pyosMeta

A package that updates pyOpenSci contributor and package metadata on our website
BSD 3-Clause "New" or "Revised" License
4 stars 17 forks source link

Fix: field alias for date_accepted field #114

Closed lwasser closed 6 months ago

lwasser commented 6 months ago

Rather than fixing the entire thing i'm working towards cleaning up the parse_issues method. This is a small fix that

  1. adds a field alias to pydantic so there's not a random date field cleanup step in an unexpected place.
  2. adds a small test to ensure the both aliases defined in the model work

i'm guessing there are better ways to setup tests like this but it's a start and i'm trying to keep this contained. this addresses #91 in (a very small) part.

lwasser commented 6 months ago

oops failing. moving to draft

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.00%. Comparing base (1c51a92) to head (922333d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #114 +/- ## ========================================== + Coverage 41.64% 44.00% +2.36% ========================================== Files 4 4 Lines 461 459 -2 Branches 74 73 -1 ========================================== + Hits 192 202 +10 + Misses 268 253 -15 - Partials 1 4 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.