Closed willingc closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 47.56%. Comparing base (
1d3396c
) to head (89b26eb
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@lwasser It's fine to have 1 function in a module or 1 test in a file. I tend to lean toward separation of concepts. If we had one file called utils.py
, then I would create test_utils.py
(which would include all utilities). Since we split the utils into two files which makes good sense utils_clean.py
and utils_parse.py
, I like to match the test files to the source file. It requires less thought on my part since I know my tests are almost always in a file test_sourcefilename.py
when sourcefilename.py
is the code file.
Keep the great questions coming too.
Thank you @willingc !! That makes sense!!
This small PR breaks up the existing test file for utilities into two test files following the refactor in #121 and #120. No tests were changed.