search

pyOpenSci / pyosMeta

A package that updates pyOpenSci contributor and package metadata on our website
BSD 3-Clause "New" or "Revised" License
4 stars 17 forks source link

Fix: Move all of the github things to a new module for easier maintenance #132

Closed lwasser closed 6 months ago

lwasser commented 6 months ago

this is the first part of addressing #125

it moves all of the gh methods from parse issues into a new module. tests are still needed so opening as a draft.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 40.57971% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 56.80%. Comparing base (1f50afb) to head (b9ed165).

Files Patch % Lines
src/pyosmeta/github_api.py 43.63% 31 Missing :warning:
src/pyosmeta/parse_issues.py 28.57% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #132 +/- ## ========================================== - Coverage 57.05% 56.80% -0.26% ========================================== Files 7 8 +1 Lines 482 500 +18 Branches 76 78 +2 ========================================== + Hits 275 284 +9 - Misses 202 211 +9 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lwasser commented 6 months ago

weird. the test that won't run on my computer runs here. i don't understand temp directories and pytest. it should run in both places.

lwasser commented 6 months ago

ok i am going to merge this pr. tests are passing, the red x is code cover is unhappy but we are moving forward in test coverage even if code code is unhappy! the next PR will be to migrate all of the github API calls from process_contribs to the new ghapi module!