Closed lwasser closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 60.55%. Comparing base (
a0cfaa8
) to head (34254ff
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@willingc this PR got a lot bigger than i expected. I tried to add some tests which ended up including some fixtures which ended up leading to my finding that docstrings and such were missing / unclear. i suspect this is not one of my better / more clean pr's so i would appreciate any high level feedback to make it more digestable. or for just future pr's being more digestable.
ok thank you so much @willingc !!! i'll merge this now! i'm glad to hear you felt it was somewhat reasonable in terms of volume of changes. it was pretty hard to scope this one!
This should close #125 it's the second half of migrating all of our github methods into the github_api module.
It also adds some docstrings and clarification in some of the methods.
i am going to add a few tests as well once we know everything is passing as is.