search

pyOpenSci / pyosMeta

A package that updates pyOpenSci contributor and package metadata on our website
BSD 3-Clause "New" or "Revised" License
4 stars 17 forks source link

Fix: refactor github methods out of contributor mod #138

Closed lwasser closed 5 months ago

lwasser commented 5 months ago

This should close #125 it's the second half of migrating all of our github methods into the github_api module.

It also adds some docstrings and clarification in some of the methods.

i am going to add a few tests as well once we know everything is passing as is.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.55%. Comparing base (a0cfaa8) to head (34254ff). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #138 +/- ## ========================================== + Coverage 57.56% 60.55% +2.98% ========================================== Files 8 8 Lines 502 502 Branches 78 79 +1 ========================================== + Hits 289 304 +15 + Misses 208 193 -15 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lwasser commented 5 months ago

@willingc this PR got a lot bigger than i expected. I tried to add some tests which ended up including some fixtures which ended up leading to my finding that docstrings and such were missing / unclear. i suspect this is not one of my better / more clean pr's so i would appreciate any high level feedback to make it more digestable. or for just future pr's being more digestable.

lwasser commented 5 months ago

ok thank you so much @willingc !!! i'll merge this now! i'm glad to hear you felt it was somewhat reasonable in terms of volume of changes. it was pretty hard to scope this one!