search

pyOpenSci / pyosMeta

A package that updates pyOpenSci contributor and package metadata on our website
BSD 3-Clause "New" or "Revised" License
4 stars 18 forks source link

Add: pagination support for issue requests #140

Closed lwasser closed 7 months ago

lwasser commented 7 months ago

A pr to support pagination when we fetch issues. Working locally on summary values for total submissions over time, etc

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 58.95%. Comparing base (b368421) to head (355c7dd).

Files Patch % Lines
src/pyosmeta/github_api.py 10.00% 18 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #140 +/- ## ========================================== - Coverage 60.55% 58.95% -1.60% ========================================== Files 8 8 Lines 502 519 +17 Branches 79 82 +3 ========================================== + Hits 304 306 +2 - Misses 193 208 +15 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lwasser commented 7 months ago

this pr is actually working really well now! its "failing" because of a decrease in test coverage not because of failing tests.

lwasser commented 7 months ago

I am going to merge this. I think the tests for these api calls are more involved and i'd like to do it in a separate pr. i'll open an issue for that so we have the functionality for this now.

willingc commented 7 months ago

Closes #139