Final series lessons - pyproject, code of conduct & license files

[lwasser]

This is the last in the first packaging series of lessons to review. once these are merged we will need to run through the entire set to ensure it's coherent! especially with the move to hatch :)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1206595156181276
  • https://app.asana.com/0/0/1206477992353057

[lwasser]

@all-contributors please add @xmnlab for code, review, tutorial

[allcontributors[bot]]

@lwasser

I've put up a pull request to add @xmnlab! :tada:

[lwasser]

ok y'all. i've made a bunch of changes. @sneakers-the-rat the plan is to merge this today. IF you are busy and can't rebase those other pr's then what we can do is i can merge it and you can submit the pr directly to this repo to the main branch and we can review next week!! i'll leave this open until the end of the day with the plan of merging this evening sometime after 5pm mountain time!

[lwasser]

ok friends. i made a lot of structural changes to the content (including adding that amazing highlighting mst plugin - wow !!). so things are much more organized now. i'll let this sit (i have a meeting to go to in just a bit) for a few hours with the plan of merging it this evening after my last meetings.

@sneakers-the-rat i will look at the pr's - i just noticed there are a bunch in my fork. we can either rebase or submit directly to the main branch here for easier merging. i suspect some of them might have been before i rebased my branch but i could be wrong there too! i did integrate some of your suggestions - like the code highlighting in the pyproject.toml file here already!! it's SO MUCH BETTER with that - adding to the file in each step. wow.

[sneakers-the-rat]

Oh ya i was PR'ing to lwasser/license-pyproject bc was trying to add suggestions to this PR, but can just to to main branch if that's better. a lot of my suggestions are trashed after the restructuring here (whish is good and fine!) so i'll split them up and redo them. mostly formatting and order stuff, nothing major contentwise bc this is good imo

[lwasser]

Oh ya i was PR'ing to lwasser/license-pyproject bc was trying to add suggestions to this PR, but can just to to main branch if that's better. a lot of my suggestions are trashed after the restructuring here (whish is good and fine!) so i'll split them up and redo them. mostly formatting and order stuff, nothing major contentwise bc this is good imo

i'm really sorry about that @sneakers-the-rat i think what happened is i didn't see those pr's at all and i'm not used to that workflow with this community. not that it isn't ok i just didn't think to look at my fork. i was so focused on the comments in this pr that i wasn't paying attention to my fork. When you mentioned pr's i just thought perhaps they would pop up here. that is my mistake in missing those. i do want your feedback so please don't think i was ignoring the work you did there. i just literally missed it amid everything else going on. please know that i feel really bad about that but would love pr's directly here!

[sneakers-the-rat]

@lwasser you are all good - i should have flagged those more clearly. I split them up and redid them, and if you want to merge this now then np we can change the base discuss them separately :)

edit to avoid the same problem again lmao those are

• https://github.com/lwasser/python-package-guide/pull/10
• https://github.com/lwasser/python-package-guide/pull/9
• https://github.com/lwasser/python-package-guide/pull/8

[lwasser]

ok friends. i am going to MERGE this pr!! This is a huge milestone as it's the final touches to the first set of pyOpenSci tutorials!! We can improve / fix / enhance from here. i'll also create a new release of the guidebook in the upcoming week or two that should include all of the new contributors. Please stay tuned for that.

[lwasser]

ok @sneakers-the-rat yes let's look at this here via pr's to the main branch. thank you so so much for this work. i just wanted to get this big pr merged and then we can look at all of the changes you have suggested together. many many thanks!!

[sneakers-the-rat]

Nice job team ♥