search

pyOpenSci / python-package-guide

Scientific Python package recommendations & guidance curated by pyOpenSci
https://www.pyopensci.org/python-package-guide/
Other
103 stars 56 forks source link

Fix: reorganize index structure for users #188

Closed lwasser closed 8 months ago

lwasser commented 8 months ago

this is a pr from @sneakers-the-rat that was sent to my fork. i'm moving it here so we can work on it once the other pr #181 is merged in a few hours!

lwasser commented 8 months ago

@sneakers-the-rat it looks like i tried to start rerouting your pr's here. is this one we should rebase and look at together? or can you reroute pr's that were on my fork to the main branch here?

sneakers-the-rat commented 8 months ago

Ya ya will do shortly ♥

willingc commented 8 months ago

@sneakers-the-rat @lwasser What is the next step for this PR? Rebase?

lwasser commented 8 months ago

ok i can't approve it but i should be able to make edits to the files. i'm really confused

lwasser commented 8 months ago

Let's merge and i'll make the changes myself in a separate pr

sneakers-the-rat commented 8 months ago

Works for me. Wonder what happened !?

willingc commented 8 months ago

Thanks for doing this @lwasser and @sneakers-the-rat. That's the first that I have seen that as an admin. If it happens again, let me know.

lwasser commented 8 months ago

so odd. Here is my theory @sneakers-the-rat @willingc ... i think i actually opened this pr because Jonny had opened the pr against my other pr and i had missed them (they were in my fork). So i didn't want to lose jonny's ideas and re-opened the pr against the main branch. But the pr is still from jonny's fork.

and i wonder if i didn't check "allow maintainer edits" or something? which is weird because i'm an owner of this repo but i created a PR from a fork that i do not own. i'm really not sure :) but i just made those 2 tiny edits to the headers in a separate pr so all good. the changes here as fantastic!! Thank you Jonny for submitting this and being so thoughtful about user experience of our guide!

lwasser commented 8 months ago

and @willingc thank you for helping with handling all of these pr's. i am definitely behind so this is hugely helpful to be able to pop in and review / merge or just for you to merge things that are ready to go!!