search

pyOpenSci / python-package-guide

scientific Python package recommendations & guidance curated by pyOpenSci
https://www.pyopensci.org/python-package-guide/
Other
70 stars 43 forks source link

More consistent LICENSE and CODE_OF_CONDUCT usage #234

Closed ptressel closed 2 months ago

ptressel commented 2 months ago

Use uppercase and fixed-pitch when references to license and code of conduct are more likely references to actual files. (No formatting added in alt text.) Also tweak a few grammatical issues.

lwasser commented 2 months ago

@all-contributors please add @ptressel for code, review

allcontributors[bot] commented 2 months ago

@lwasser

I've put up a pull request to add @ptressel! :tada:

lwasser commented 2 months ago

@ucodery i'm totally happy for you to merge these types of pr's as you feel comfortable! i'll go ahead and merge this one. I think the only time we want to have a broader review is if we're changing content . So for instance it was helpful to have ofek review the hatch content since we were updating things - he ensured it was accurate. Or if we add a new section or page to the guide we want to let our community know and have an open review period. but if the changes are fixes like this - we can review and merge :) thank you for this approval. now !