pyOpenSci / software-submission

Submit your package for review by pyOpenSci here! If you have questions please post them here: https://pyopensci.discourse.group/
95 stars 35 forks source link

Presubmission Inquiry for GALAssify: A Python package for visually classifying astronomical objects #189

Closed Manalclay closed 2 months ago

Manalclay commented 6 months ago

Submitting Author: Name (@github_handle)
Package Name: GALAssify One-Line Description of Package: A Python package for visually classifying astronomical objects Repository Link (if existing): https://gitlab.com/astrogal/GALAssify/


Code of Conduct & Commitment to Maintain Package

Description

Community Partnerships

We partner with communities to support peer review with an additional layer of checks that satisfy community requirements. If your package fits into an existing community please check below:

Scope

Scope

Domain Specific

Community Partnerships

If your package is associated with an existing community please check below:

P.S. Have feedback/comments about our review process? Leave a comment here

hamogu commented 6 months ago

Thanks for your presubmission inquiry. I'm just wondering: Your package was initially developed with astronomical data in mind and uses some parts of astropy (in particular astropy.io.fits), although, as you say, it's in principle it's use case is more general. So, I'm just wondering if you intend this package to also be considered for astropy-affiliation as part of the pyopensci review process (in addition to the general PyOpenSci listing) or not. No pressure either way - it's certainly your choice. I just want to make sure that it's not just an oversight to tick the astropy box in the form.

Manalclay commented 6 months ago

Hi @hamogu,

I misunderstood the purpose of the astropy tick box. At the moment we do not aim GALAssify to be an affiliated astropy package. I'm editing the description and unticking this box now.

Thanks for noticing!

dhomeier commented 6 months ago

I misunderstood the purpose of the astropy tick box. At the moment we do not aim GALAssify to be an affiliated astropy package. I'm editing the description and unticking this box now.

Thanks for the clarification! You are still welcome to adhere to the Astropy community standards and acknowledge so; the crucial element for becoming an affiliated package is setting the astropy label, so we just needed to confirm that we don't set that.

Manalclay commented 5 months ago

Thanks to you for the information, we confirm that we do not set the astropy label for this submission.

Batalex commented 5 months ago

Hello @Manalclay, welcome to pyOpenSci! Data annotation/labelling is a task of utmost importance to the scientific community. I definitely think that GALAssify is in scope for us. Would you mind opening a new submission issue referencing this pre-submission? Thank you.

Manalclay commented 5 months ago

Hello @Batalex , thank you for your words!

Yes, we plan to open a submission referencing this pre-submission issue. While reading the Technical Checks of the submission form, we found that we must have a test suite and a continuous integration setup in order to satisfy the submission requirements. We are currently working on that. Once we have it working, we will open the submission.

Thanks for your time and your patience.

Manalclay commented 2 months ago

Hello again! Thanks for your patience.

Finally, I could get the testing suite and the CI working flawlessly in the package repo. Therefore, I just open a submission for this package: https://github.com/pyOpenSci/software-submission/issues/214

Thanks again for all your help and patience. I hope this package can be useful for someone as it was to me!

cmarmo commented 2 months ago

Thank you @Manalclay ! I'm going to close this presubmission then.