pyOpenSci / test-pyos-review

This is a test repository that we will use to setup our bot. please do not submit packages here.
0 stars 0 forks source link

submit fake review by leah #6

Closed lwasser closed 4 months ago

lwasser commented 4 months ago

Submitting Author: AUTHOR_NAME (!--author-handle-->@AUTHOR_GITHUB_HANDLE<!--end-author-handle--) All current maintainers: (@github_handle1, @github_handle2) Package Name: Package name here One-Line Description of Package: Description here Repository Link: URL_OF_THE_SOFTWARE_REPO Version submitted: VERSION Editor: !--editor-->@xuanxu<!--end-editor--
Reviewers:
Archive: TBD JOSS DOI: TBD Version accepted: TBD
Date accepted (month/day/year): TBD


Code of Conduct & Commitment to Maintain Package

Description

Scope

Domain Specific

Community Partnerships

If your package is associated with an existing community please check below:

[^1]: Please fill out a pre-submission inquiry before submitting a data visualization package.

Technical checks

For details about the pyOpenSci packaging requirements, see our packaging guide. Confirm each of the following by checking the box. This package:

Publication Options

JOSS Checks - [ ] The package has an **obvious research application** according to JOSS's definition in their [submission requirements][JossSubmissionRequirements]. Be aware that completing the pyOpenSci review process **does not** guarantee acceptance to JOSS. Be sure to read their submission requirements (linked above) if you are interested in submitting to JOSS. - [ ] The package is not a "minor utility" as defined by JOSS's [submission requirements][JossSubmissionRequirements]: "Minor ‘utility’ packages, including ‘thin’ API clients, are not acceptable." pyOpenSci welcomes these packages under "Data Retrieval", but JOSS has slightly different criteria. - [ ] The package contains a `paper.md` matching [JOSS's requirements][JossPaperRequirements] with a high-level description in the package root or in `inst/`. - [ ] The package is deposited in a long-term repository with the DOI: *Note: JOSS accepts our review as theirs. You will NOT need to go through another full review. JOSS will only review your paper.md file. Be sure to link to this pyOpenSci issue when a JOSS issue is opened for your package. Also be sure to tell the JOSS editor that this is a pyOpenSci reviewed package once you reach this step.*

Are you OK with Reviewers Submitting Issues and/or pull requests to your Repo Directly?

This option will allow reviewers to open smaller issues that can then be linked to PR's rather than submitting a more dense text based review. It will also allow you to demonstrate addressing the issue via PR links.

Confirm each of the following by checking the box.

Please fill out our survey

P.S. Have feedback/comments about our review process? Leave a comment here

Editor and Review Templates

The editor template can be found here.

The review template can be found here.

pyosbot commented 4 months ago

Hey @lwasser :wave: welcome to pyOpenSci’s scientific Python peer review process!

We’ve seen your message. Someone from our editorial team will get back to you within the next week about this submission. In the meantime, feel free to check out our packaging guide or feel free to ask questions on our Discourse forum.

lwasser commented 4 months ago

@pyosbot help

pyosbot commented 4 months ago

Hello @lwasser, here are the things you can ask me to do:


# List all available commands
@pyosbot help

# Show our community Code of Conduct and Guidelines
@pyosbot code of conduct

# Allow editors to move the review to EiC checks
@pyosbot assign eic

# Get a list of all editors's GitHub handles
@pyosbot list editors

# Assign a user as the editor of this submission
@pyosbot assign @username as editor

# Label issue with: 2/seeking-reviewers. Remove labels: 1/editor-assigned
@pyosbot seeking reviewers

# Set a value for version
@pyosbot set v1.0.0 as version

# Set a value for archive
@pyosbot set 10.5281/zenodo.7158585 as archive
lwasser commented 4 months ago

@pyosbot assign @lwasser as editor

pyosbot commented 4 months ago

Assigned! @lwasser is now the editor

lwasser commented 4 months ago

@pyosbot remove @lwasser as editor

pyosbot commented 4 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@pyosbot help

lwasser commented 4 months ago

@pyosbot help

pyosbot commented 4 months ago

Hello @lwasser, here are the things you can ask me to do:


# List all available commands
@pyosbot help

# Show our community Code of Conduct and Guidelines
@pyosbot code of conduct

# Allow editors to move the review to EiC checks
@pyosbot assign eic

# Get a list of all editors's GitHub handles
@pyosbot list editors

# Assign a user as the editor of this submission
@pyosbot assign @username as editor

# Remove the editor assigned to this submission
@pyosbot remove editor

# Label issue with: 2/seeking-reviewers. Remove labels: 1/editor-assigned
@pyosbot seeking reviewers

# Set a value for version
@pyosbot set v1.0.0 as version

# Set a value for archive
@pyosbot set 10.5281/zenodo.7158585 as archive

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@pyosbot remind @reviewer in 2 weeks
lwasser commented 4 months ago

@pyosbot remind @reviewer in 1 day

pyosbot commented 4 months ago

@reviewer doesn't seem to be a reviewer or author for this submission.

xuanxu commented 4 months ago

@pyosbot remove @lwasser as editor

Two options here: assign other editor to remove the current one, or add the remove_editor responder to the config file

xuanxu commented 4 months ago

@pyosbot assign me as editor

lwasser commented 4 months ago

@xuanxu i broke the bot again 😢 i can't figure out what i did this time

xuanxu commented 4 months ago

:) Let me take a look

lwasser commented 4 months ago

thank you 😆

pyosbot commented 4 months ago

Assigned! @xuanxu is now the editor

xuanxu commented 4 months ago

Fixed! I found two errors:

lwasser commented 4 months ago

oh - the add_labels / add-labels was a mistake but i didn't realize the label_command was one responded with the ability to add multiple "commands" for that responder. i thought you had to add individual label_command elements rather than an array of commands within the responded.

thank you so much - this is helpful to see

xuanxu commented 4 months ago

oh - the add_labels / add-labels was a mistake but i didn't realize the label_command was one responded with the ability to add multiple "commands" for that responder. i thought you had to add individual label_command elements rather than an array of commands within the responded.

Yeah, this is the same for every responder: when you want multiple instances of a responder you have to configure an array of them