pySTEPS / pysteps

Python framework for short-term ensemble prediction systems.
https://pysteps.github.io/
BSD 3-Clause "New" or "Revised" License
466 stars 168 forks source link

Refactor `utils.interpolate` module #210

Closed dnerini closed 3 years ago

dnerini commented 3 years ago

Closes #209.

RTD built: https://pysteps.readthedocs.io/en/refactor-interpolate/

codecov[bot] commented 3 years ago

Codecov Report

Merging #210 (a5a1a44) into master (76324d8) will increase coverage by 0.63%. The diff coverage is 97.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   78.01%   78.65%   +0.63%     
==========================================
  Files         131      133       +2     
  Lines        9640     9813     +173     
==========================================
+ Hits         7521     7718     +197     
+ Misses       2119     2095      -24     
Flag Coverage Δ
unit_tests 78.65% <97.68%> (+0.63%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysteps/motion/lucaskanade.py 93.42% <ø> (ø)
pysteps/tests/test_nowcasts_steps.py 100.00% <ø> (ø)
pysteps/utils/images.py 76.92% <ø> (ø)
pysteps/io/importers.py 71.65% <42.85%> (ø)
pysteps/nowcasts/sseps.py 87.39% <50.00%> (ø)
pysteps/utils/interpolate.py 98.18% <98.11%> (+33.89%) :arrow_up:
pysteps/decorators.py 99.14% <100.00%> (+1.52%) :arrow_up:
pysteps/io/exporters.py 52.35% <100.00%> (ø)
pysteps/tests/test_decorators.py 100.00% <100.00%> (ø)
pysteps/tests/test_utils_interpolate.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76324d8...a5a1a44. Read the comment docs.

pulkkins commented 3 years ago

Great work @dnerini. To me this looks like it's almost ready for merging (see my comment above). I made some minor fixes to docstrings.

dnerini commented 3 years ago

Thanks a lot @aperezhortal @loforest @pulkkins for your reviews!

I'm merging the PR.