pySTEPS / pysteps

Python framework for short-term ensemble prediction systems.
https://pysteps.github.io/
BSD 3-Clause "New" or "Revised" License
466 stars 168 forks source link

Add KNMI Harmonie NWP importer and tests #235

Closed RubenImhoff closed 3 years ago

RubenImhoff commented 3 years ago

Following earlier commits by @cvelascof and @ladc, I'm also adding a KNMI nwp importer. At a later stage, we should try to make a more universal importer for all nwp products.

codecov[bot] commented 3 years ago

Codecov Report

Merging #235 (560cb35) into pysteps-v2 (56bd0e9) will decrease coverage by 0.07%. The diff coverage is 97.26%.

:exclamation: Current head 560cb35 differs from pull request most recent head e9b3632. Consider uploading reports for the commit e9b3632 to get more accurate results Impacted file tree graph

@@              Coverage Diff               @@
##           pysteps-v2     #235      +/-   ##
==============================================
- Coverage       73.51%   73.44%   -0.08%     
==============================================
  Files             145      146       +1     
  Lines           10980    10957      -23     
==============================================
- Hits             8072     8047      -25     
- Misses           2908     2910       +2     
Flag Coverage Δ
unit_tests 73.44% <97.26%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysteps/io/nwp_importers.py 89.52% <95.74%> (+1.85%) :arrow_up:
pysteps/tests/test_io_knmi_nwp.py 100.00% <100.00%> (ø)
pysteps/tests/test_datasets.py 42.85% <0.00%> (-2.60%) :arrow_down:
pysteps/tests/test_plugins_support.py 47.05% <0.00%> (-1.52%) :arrow_down:
pysteps/tests/test_nowcasts_steps.py 21.56% <0.00%> (-1.51%) :arrow_down:
pysteps/tests/test_cascade.py 45.71% <0.00%> (-1.51%) :arrow_down:
pysteps/tests/test_plt_cartopy.py 83.33% <0.00%> (-0.88%) :arrow_down:
pysteps/tests/test_nowcasts_anvil.py 86.95% <0.00%> (-0.55%) :arrow_down:
pysteps/tests/test_nowcasts_sprog.py 86.95% <0.00%> (-0.55%) :arrow_down:
pysteps/tests/test_nowcasts_sseps.py 87.50% <0.00%> (-0.50%) :arrow_down:
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56bd0e9...e9b3632. Read the comment docs.