search

pySTEPS / pysteps

Python framework for short-term ensemble prediction systems.
https://pysteps.github.io/
BSD 3-Clause "New" or "Revised" License
466 stars 168 forks source link

Support for matplotlib 3.5 #246

Closed dnerini closed 2 years ago

dnerini commented 2 years ago

Released on Nov 15, matplotlib 3.5 introduced few breaking changes that affected us very marginally (but still broke our doc build...):

semilogx, semilogy, loglog, LogScale, and SymmetricalLogScale used to take keyword arguments that depends on the axis orientation ("basex" vs "basey", "subsx" vs "subsy", "nonposx" vs "nonposy"); these parameter names have been removed in favor of "base", "subs", "nonpositive". This removal also affects e.g. ax.set_yscale("log", basey=...) which must now be spelled ax.set_yscale("log", base=...).

Realease notes

This PR fixes them.

codecov[bot] commented 2 years ago

Codecov Report

Merging #246 (9d5cddd) into master (ecbe196) will decrease coverage by 0.00%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   80.78%   80.77%   -0.01%     
==========================================
  Files         140      140              
  Lines       10625    10625              
==========================================
- Hits         8583     8582       -1     
- Misses       2042     2043       +1
Flag Coverage Δ
unit_tests 80.77% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysteps/verification/plots.py 11.11% <0.00%> (ø)
pysteps/io/importers.py 71.73% <0.00%> (-0.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ecbe196...9d5cddd. Read the comment docs.