pySTEPS / pysteps

Python framework for short-term ensemble prediction systems.
https://pysteps.github.io/
BSD 3-Clause "New" or "Revised" License
466 stars 168 forks source link

Ensure clim window has same size as skill today and place forecast_prev update at end of extrapolation loop #274

Closed RubenImhoff closed 2 years ago

RubenImhoff commented 2 years ago

This PR makes two minor changes that impact the climatological skill calculation and the extrapolation loop in the steps blending code when subtimesteps are used.

Changes:

codecov[bot] commented 2 years ago

Codecov Report

Merging #274 (b553bb2) into master (8936236) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files         158      158           
  Lines       12130    12130           
=======================================
  Hits         9986     9986           
  Misses       2144     2144           
Flag Coverage Δ
unit_tests 82.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysteps/blending/clim.py 100.00% <ø> (ø)
pysteps/blending/steps.py 83.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8936236...b553bb2. Read the comment docs.