pySTEPS / pysteps

Python framework for short-term ensemble prediction systems.
https://pysteps.github.io/
BSD 3-Clause "New" or "Revised" License
466 stars 168 forks source link

Fmi geotiff importer fixes #284

Closed pulkkins closed 2 years ago

pulkkins commented 2 years ago

This pull request contains the following fixes to the FMI GeoTIFF importer (io.importers.import_fmi_geotiff):

codecov[bot] commented 2 years ago

Codecov Report

Merging #284 (c07b601) into master (f3216b2) will increase coverage by 0.26%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   82.39%   82.66%   +0.26%     
==========================================
  Files         158      159       +1     
  Lines       12165    12180      +15     
==========================================
+ Hits        10023    10068      +45     
+ Misses       2142     2112      -30     
Flag Coverage Δ
unit_tests 82.66% <100.00%> (+0.26%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysteps/tests/test_io_fmi_pgm.py 100.00% <ø> (ø)
pysteps/io/importers.py 76.37% <100.00%> (+4.34%) :arrow_up:
pysteps/tests/test_io_fmi_geotiff.py 100.00% <100.00%> (ø)
pysteps/io/exporters.py 54.84% <0.00%> (-0.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3216b2...c07b601. Read the comment docs.

dnerini commented 2 years ago

Very good, thanks, you can go ahead and merge into master once all tests are green.