NathalieRombeek commented 2 years ago

Implement option of blending based on the salience weight method, which considers the intensity of the storms, so that cells with high intensity will have a stronger weight during the blending (and hence a longer lifetime). The paper describing this method is this one:

https://journals.ametsoc.org/view/journals/wefo/30/5/waf-d-15-0057_1.xml

RubenImhoff commented 2 years ago

Great work, Nathalie! I'll have a look at it soon. :)

codecov[bot] commented 2 years ago

Codecov Report

Merging #285 (102227a) into master (99c79d8) will increase coverage by 0.37%. The diff coverage is 98.18%.

:exclamation: Current head 102227a differs from pull request most recent head 166e116. Consider uploading reports for the commit 166e116 to get more accurate results

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   82.34%   82.71%   +0.37%     
==========================================
  Files         158      159       +1     
  Lines       12142    12217      +75     
==========================================
+ Hits         9998    10105     +107     
+ Misses       2144     2112      -32

Flag	Coverage Δ
unit_tests	`82.71% <98.18%> (+0.37%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pysteps/blending/linear_blending.py	`87.34% <97.43%> (+6.57%)`	:arrow_up:
pysteps/blending/interface.py	`56.25% <100.00%> (+6.25%)`	:arrow_up:
pysteps/tests/test_blending_linear_blending.py	`100.00% <100.00%> (ø)`
pysteps/io/exporters.py	`54.84% <0.00%> (-0.28%)`	:arrow_down:
pysteps/blending/steps.py	`83.89% <0.00%> (-0.03%)`	:arrow_down:
pysteps/tests/test_io_fmi_pgm.py	`100.00% <0.00%> (ø)`
pysteps/tests/test_tracking_tdating.py	`100.00% <0.00%> (ø)`
pysteps/tests/test_io_fmi_geotiff.py	`100.00% <0.00%> (ø)`
pysteps/tracking/tdating.py	`91.47% <0.00%> (+1.70%)`	:arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 99c79d8...166e116. Read the comment docs.

dnerini commented 2 years ago

Congratulations @NathalieRombeek on your first and excellent contribution to pysteps!

pySTEPS / pysteps

Implement option for saliency-based blending #285

Codecov Report