pySTEPS / pysteps

Python framework for short-term ensemble prediction systems.
https://pysteps.github.io/
BSD 3-Clause "New" or "Revised" License
466 stars 168 forks source link

[ERAD] Add test cleansing error is raise when input has nans #296

Closed aperezhortal closed 2 years ago

aperezhortal commented 2 years ago

This PR adds a test for the cleansing function that checks that an error is raised when input has nans.

codecov[bot] commented 2 years ago

Codecov Report

Base: 82.76% // Head: 82.73% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (20b7086) compared to base (0cc4488). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 20b7086 differs from pull request most recent head 57ac39f. Consider uploading reports for the commit 57ac39f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #296 +/- ## ========================================== - Coverage 82.76% 82.73% -0.04% ========================================== Files 161 160 -1 Lines 12328 12299 -29 ========================================== - Hits 10203 10175 -28 + Misses 2125 2124 -1 ``` | Flag | Coverage Δ | | |---|---|---| | unit_tests | `82.73% <100.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pySTEPS#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/pySTEPS/pysteps/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pySTEPS) | Coverage Δ | | |---|---|---| | [pysteps/tests/test\_utils\_cleansing.py](https://codecov.io/gh/pySTEPS/pysteps/pull/296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pySTEPS#diff-cHlzdGVwcy90ZXN0cy90ZXN0X3V0aWxzX2NsZWFuc2luZy5weQ==) | `100.00% <100.00%> (ø)` | | | [pysteps/io/nowcast\_importers.py](https://codecov.io/gh/pySTEPS/pysteps/pull/296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pySTEPS#diff-cHlzdGVwcy9pby9ub3djYXN0X2ltcG9ydGVycy5weQ==) | `79.38% <0.00%> (-0.42%)` | :arrow_down: | | [pysteps/feature/tstorm.py](https://codecov.io/gh/pySTEPS/pysteps/pull/296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pySTEPS#diff-cHlzdGVwcy9mZWF0dXJlL3RzdG9ybS5weQ==) | `94.40% <0.00%> (ø)` | | | [pysteps/tracking/tdating.py](https://codecov.io/gh/pySTEPS/pysteps/pull/296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pySTEPS#diff-cHlzdGVwcy90cmFja2luZy90ZGF0aW5nLnB5) | `91.47% <0.00%> (ø)` | | | [...teps/tests/test\_nowcasts\_lagrangian\_probability.py](https://codecov.io/gh/pySTEPS/pysteps/pull/296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pySTEPS#diff-cHlzdGVwcy90ZXN0cy90ZXN0X25vd2Nhc3RzX2xhZ3JhbmdpYW5fcHJvYmFiaWxpdHkucHk=) | `100.00% <0.00%> (ø)` | | | [pysteps/tests/test\_io\_nowcast\_importers.py](https://codecov.io/gh/pySTEPS/pysteps/pull/296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pySTEPS#diff-cHlzdGVwcy90ZXN0cy90ZXN0X2lvX25vd2Nhc3RfaW1wb3J0ZXJzLnB5) | | | | [pysteps/utils/cleansing.py](https://codecov.io/gh/pySTEPS/pysteps/pull/296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pySTEPS#diff-cHlzdGVwcy91dGlscy9jbGVhbnNpbmcucHk=) | `82.82% <0.00%> (+1.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pySTEPS). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pySTEPS)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.