chiara-arpae commented 2 years ago

[ERAD]Test that input arrays with more than 2 dimensions raise a ValueError exception](https://app.codecov.io/gh/pySTEPS/pysteps/compare/283/tree/pysteps/utils/cleansing.py#D1L173)

dnerini commented 2 years ago

hey @chiara-arpae please let us know if something is not clear in the comments left above. The pull request is almost ready to be merged, just few final changes are needed ;)

chiara-arpae commented 2 years ago

Hi! I'm very sorry for late. I should have committed the suggested correction few minutes ago. Please let me know if it's all fine.

chiara-arpae commented 2 years ago

Hi, I'm very sorry for late. I should have committed the correction but I received a message about check black failing from Github. I realized I have modified and committed on master branch, instead of doing it on the branch 'test_cleaning_2d'. Maybe could it depend on that? Sorry very much for mess. If you could help me I'd be grateful.

Il giorno ven 16 set 2022 alle ore 10:32 Daniele Nerini < @.***> ha scritto:

hey @chiara-arpae https://github.com/chiara-arpae please let us know if something is not clear in the comments left above. The pull request is almost ready to be merged, just few final changes are needed ;)

— Reply to this email directly, view it on GitHub https://github.com/pySTEPS/pysteps/pull/298#issuecomment-1249080374, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ2PKGSGINQDM24BD7VMYZDV6QWCFANCNFSM573BL2AA . You are receiving this because you were mentioned.Message ID: @.***>

codecov[bot] commented 2 years ago

Codecov Report

Merging #298 (dd3685d) into master (94a11b3) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   82.71%   82.74%   +0.03%     
==========================================
  Files         160      160              
  Lines       12292    12310      +18     
==========================================
+ Hits        10167    10186      +19     
+ Misses       2125     2124       -1

Flag	Coverage Δ
unit_tests	`82.74% <100.00%> (+0.03%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pysteps/utils/cleansing.py	`82.82% <ø> (+1.01%)`	:arrow_up:
pysteps/tests/test_utils_cleansing.py	`100.00% <100.00%> (ø)`
pysteps/feature/tstorm.py	`94.40% <0.00%> (ø)`
pysteps/tracking/tdating.py	`91.47% <0.00%> (ø)`
...teps/tests/test_nowcasts_lagrangian_probability.py	`100.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dnerini commented 2 years ago

hey @chiara-arpae no worries and thanks for getting back on this! It looks good to go! :-)

pySTEPS / pysteps

Add test outlier detection #298

Codecov Report