Closed RubenImhoff closed 4 months ago
The failed tests seem to be unrelated to the changes in this PR. It is related to opencv, it seems, does something go wrong with the installation of that in some of the python versions?
@RubenImhoff just to understand, did you fork this from master or from #351 ?
This PR is forked from master, indeed (independent from #351)
it should be fixed on master now, can you merge master into this branch @RubenImhoff to see if now tests pass?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.33%. Comparing base (
bdfa575
) to head (bc93143
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks, Daniele! I also added some tests, but couldn't find a way to assert if the passed new arguments also end up in the netCDF. If you know a way, let me know, otherwise this should be good as is.
Improvement to netCDF exporter to add optional arguments scale, offset, fill_value and datatype for reduced storage possibilities. In addition, some kwargs are add to make it possible to add documentation or explanatory strings to the netCDF file.