Closed RubenImhoff closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.82%. Comparing base (
3121cbf
) to head (64c8250
). Report is 7 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks! I haven't used custom timesteps so far, so just to check -I thought it was allowed to have non-integer timesteps if you specify custom ones, so what happens in that case? (maybe requires a ceil?)
That is a good point, @ladc! I have not tested that (yet), but I can imagine that a ceil would solve that potential issue. Should we make sure that the number gets rounded up in that case to ensure that the non-integer timestep always falls within the total forecast length?
should this be added to the hackathon?
Fix to ensure that the
_check_inputs
function in/blending/steps.py
looks for the correctprecip_models
length when a list of timesteps instead of an integer is provided.