search

pyahmed / PyCORN

A script to extract data from ÄKTA/UNICORN result-files (.res)
46 stars 25 forks source link

A small fix #4

Closed Guillawme closed 9 years ago

Guillawme commented 9 years ago

Hi!

First of all, thanks a lot for this nice script (I saw your recent post on CCP4BB), it will really turn painless a significant part of my PhD thesis writing (which shall begin in a few months...). :smiley:

I suggest a little fix (see commit 0cc8636eb580dc6f9b774b10b6f063e91c2eeddf) that makes the script work under any python setup by just calling it from the shell command prompt.

As provided before this commit, the script could only (?) be run by typing the command

$ python /path/to/pycorn.py

Now, provided that /path/to is in the user's $PATH and pycorn.py is executable, the script can simply be called by typing

$ pycorn.py

Tested under Mac OS X 10.10.1 with Apple's default python setup. This should behave the same under any bash-like shell on any OS having a proper python setup.

Commit 5d028b8660d6bbdc28092875fbf9cc15ae1e10fe only fixes a typo in console output (or what I saw as a typo, being non native English speaker...), and makes uniform the use of the term "plotting" instead of "printing" found in another console output (only a fussy reflex from someone who proofread a couple books in the past...).

Please don't ask me to propose a more elaborate pull request: I'm totally illiterate in programming. :no_mouth:

pyahmed commented 9 years ago

Thank you for the comments. I've changed the "Plotting" to "Printing", regarding the /usr/bin/python thingy - I added something similar in the dev-branch yesterday. But your suggestion seems more general, thank you it is implemented :-)

The "Alles safe - go go go" is a silly insider-joke and is intentionally mixing german/english ;-)

Guillawme commented 9 years ago

Great! I guess I can now close this pull request.