pyamsoft / pstate-frequency

Easily control Intel p-state driver on Linux
https://pyamsoft.blogspot.com/
GNU General Public License v2.0
172 stars 19 forks source link

Align the values of the RAPL sliders #40

Closed denilsonsa closed 1 year ago

denilsonsa commented 1 year ago

Problem

Please, take a quick look at this screenshot (and I mean a quick look! don't bother reading the small numbers yet):

pstate screenshot showing short-term and long-term sliders

By just the looks alone, it looks like the Short Term value is set lower than the Long Term value. After all, the little circular handle for the Short Term is more to the left than the knob for the Long Term. However, if you spend enough time looking at it, you can read the numbers and notice the Short Term is set to 66W, while Long Term is set to 50W.

This becomes clear when we move those sliders to their extremes:

pstate screenshot showing short-term and long-term sliders fully maxed

One slider goes up to 200W, while the other only goes to 100W. However, they are both displayed at the same length, so they look like they cover the same range.

Solutions

The smaller range could have a shorter slider. In this case, half of the size. (The actual dimensions should be calculated based on the limits for the current system.)

Alternatively, both sliders could be rendered at full length, but the range after a certain amount could be disabled. Not sure if the widget supports that.

As an yet another idea, both handles could be rendered on the same slider. I'm assuming the Short Term value shouldn't ever be lower than the Long Term value, as that might be nonsensical. If that's the case, both values could be combined into a "range-slider", one with two handles, where the left-most handle is always the Long Term and the right-most is always the Short Term. (Note: this is just a guess based on my assumptions, please correct me!)

denilsonsa commented 1 year ago

Nevermind, I did something stupid. This isn't the right repository. I should fill this bug against https://github.com/frankenfruity/plasma-pstate instead.

Sorry for the noise!