The Check for Updates option doesn't appeared to be working(at least visually when no updates are found)

brlin-tw commented 5 months ago

Current behavior

After tapping the option nothing happens.

Expected behavior

TetherFi should at the very least have a toast notification saying that no updates are available.

Developer logs

[D] (SourceFile:66) App Update info received: com.google.android.play.core.appupdate.AppUpdateInfo@a3917d8 
[D] (SourceFile:112) Update is not available 
[D] (SourceFile:92) Update data found as: com.pyamsoft.pydroid.bootstrap.version.update.AppUpdateLauncher$Companion$empty$1@8a32731 
[D] (SourceFile:199) Done checking for updates

More information

This section documents the additional information that may or may not help investigate this issue:

Application version

43

Device brand and model

Google Pixel 8 Pro

Device processor architecture

ARM64

OS version

14 (AP2A.240605.024)

Locale

zh-rTW

pyamsoft commented 5 months ago

This is working as intended. I suppose I could add an extra snack bar to display no updates found, but the google in app update API is already very brittle and difficult to interface with.

pyamsoft commented 5 months ago

A change has been made to pydroid (the internal pyamsoft library that powers this feature)

When a version check is made explicitly by the user clicking the button, a snackbar will show visual feedback for "checking update" and "no update found" or "update available"

Please see here for more details. This feature will release in the next version 44!

pyamsoft commented 4 months ago

44 is in pre-release testing on the Google Play Store.

pyamsoft commented 4 months ago

The visual UI for checking for updates has been added to version 44, which has just been released on the Play store.

brlin-tw commented 4 months ago

I've installed the 44 version, and it works without issues(aside from pyamsoft/pydroid#423); thanks!

pyamsoft / tetherfi